[Workers] deploy existing remix app to workers #17379
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
assigned
aninibread,
dario-piotrowicz,
GregBrimble,
IgorMinar and
jculvey
![hyperlint-ai[bot]](https://avatars.githubusercontent.com/in/718456?s=60&v=4){kind=small}
| } from "~/components"; | ||
|
|
||
| In this guide, you will create a new [Remix](https://remix.run/) application and deploy to Cloudflare Workers (with the new [<InlineBadge preset="beta" /> Workers Assets](/workers/static-assets/)). | ||
| In this guide, you can [create a new](/workers/frameworks/framework-guides/remix/#create-a-new-application) or [deploy an existing](/workers/frameworks/framework-guides/remix/#deploy-an-existing-remix-application) [Remix](https://remix.run/) application to Cloudflare Workers with the new [<InlineBadge preset="beta" /> Workers Assets](/workers/static-assets/) feature. |
Contributor
There was a problem hiding this comment.
Suggested change
| In this guide, you can [create a new](/workers/frameworks/framework-guides/remix/#create-a-new-application) or [deploy an existing](/workers/frameworks/framework-guides/remix/#deploy-an-existing-remix-application) [Remix](https://remix.run/) application to Cloudflare Workers with the new [<InlineBadge preset="beta" /> Workers Assets](/workers/static-assets/) feature. | |
| In this guide, you can [create a new](/workers/frameworks/framework-guides/remix/#create-a-new-application) or [deploy an existing](/workers/frameworks/framework-guides/remix/#deploy-an-existing-remix-application) [Remix](https://remix.run/) application to Cloudflare Workers with the new [<InlineBadge preset="beta" /> Workers Assets](/workers/static-assets/) feature. |
Issues:
- Style Guide - (Terms-error) Use 'Workers' instead of 'workers'.
Fix Explanation:
The term 'workers' should be capitalized to 'Workers' to adhere to the style guide. This change ensures consistency and proper branding within the documentation.
Deploying cloudflare-docs with
|
| Latest commit: |
e374e1f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f43d5d7c.cloudflare-docs-7ou.pages.dev |
| Branch Preview URL: | https://remix-on-workers.cloudflare-docs-7ou.pages.dev |
Contributor
|
Files with changes (up to 15) |
GregBrimble
reviewed
Oct 7, 2024
| Generates TypeScript definitions for Cloudflare Workers. | ||
|
|
||
| ```sh | ||
| npx wrangler types |
Contributor
There was a problem hiding this comment.
I haven't looked at Remix's types in a long time. Are they compatible with --experimental-include-runtime? This has a much better experience, so if it works with this project, I'd suggest we consider documenting that here instead.
GregBrimble
reviewed
Oct 7, 2024
Comment on lines
+120
to
+130
| // This object matches the return value from Wrangler's | ||
| // `getPlatformProxy` used during development via Remix's | ||
| // `cloudflareDevProxyVitePlugin`: | ||
| // https://developers.cloudflare.com/workers/wrangler/api/#getplatformproxy | ||
| cf: request.cf, | ||
| ctx: { | ||
| waitUntil: ctx.waitUntil.bind(ctx), | ||
| passThroughOnException: ctx.passThroughOnException.bind(ctx), | ||
| }, | ||
| caches, | ||
| env, |
Contributor
There was a problem hiding this comment.
Can probably get away with just:
Suggested change
| // This object matches the return value from Wrangler's | |
| // `getPlatformProxy` used during development via Remix's | |
| // `cloudflareDevProxyVitePlugin`: | |
| // https://developers.cloudflare.com/workers/wrangler/api/#getplatformproxy | |
| cf: request.cf, | |
| ctx: { | |
| waitUntil: ctx.waitUntil.bind(ctx), | |
| passThroughOnException: ctx.passThroughOnException.bind(ctx), | |
| }, | |
| caches, | |
| env, | |
| // This object matches the return value from Wrangler's | |
| // `getPlatformProxy` used during development via Remix's | |
| // `cloudflareDevProxyVitePlugin`: | |
| // https://developers.cloudflare.com/workers/wrangler/api/#getplatformproxy | |
| cf: request.cf, | |
| ctx, | |
| caches, | |
| env, |
GregBrimble
reviewed
Oct 7, 2024
| }; | ||
| ``` | ||
|
|
||
| ### 9. Update styling |
Contributor
There was a problem hiding this comment.
Is this needed just because we're using the Classic compiler over Vite?
GregBrimble
approved these changes
Oct 7, 2024
Collaborator
|
Closing this out as it's been sitting for a while and seems stale. Can always re-open if needed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stitched together from:
Needs to be checked to make sure it follows best practices.